Uploaded image for project: 'Nuxeo Platform'
  1. Nuxeo Platform
  2. NXP-15252

Switch from net.sf.opencsv:opencsv to org.apache.commons:commons-csv

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0
    • Component/s: CSV Importer, Infrastructure
    • Impact type:
      API change
    • Upgrade notes:
      Hide

      Replaced net.sf.opencsv:opencsv:2.1 with org.apache.commons:commons-csv:1.0

      Changed protected methods:

      • org.nuxeo.ecm.csv.CSVImporterWork.doImport(au.com.bytecode.opencsv.CSVReader)
        + org.nuxeo.ecm.csv.CSVImporterWork.doImport(org.apache.commons.csv.CSVParser)
      • org.nuxeo.ecm.csv.CSVImporterWork.importLine(String[], long, int, int, String[])
        + org.nuxeo.ecm.csv.CSVImporterWork.importRecord(org.apache.commons.csv.CSVRecord, Map<String, Integer>)
      • org.nuxeo.ecm.csv.CSVImporterWork.computePropertiesMap(long, DocumentType, String[], String[])
        + org.nuxeo.ecm.csv.CSVImporterWork.computePropertiesMap(org.apache.commons.csv.CSVRecord, DocumentType, Map<String, Integer>)
      • org.nuxeo.ecm.csv.CSVImporterWork.createOrUpdateDocument(long, String, String, String, Map<String, Serializable>)
        + org.nuxeo.ecm.csv.CSVImporterWork.createOrUpdateDocument(long, String, String, Map<String, Serializable>)
      • org.nuxeo.ecm.csv.CSVImporterWork.getUserUrl(String)
        + org.nuxeo.ecm.csv.CSVImporterWork.getUserUrl()

      New Assert test methods:

      • org.nuxeo.runtime.test.Assert.assertFilesContentEquals(String, String)
      • org.nuxeo.runtime.test.Assert.assertFilesContentEquals(String, String, String)
      Show
      Replaced net.sf.opencsv:opencsv:2.1 with org.apache.commons:commons-csv:1.0 Changed protected methods: org.nuxeo.ecm.csv.CSVImporterWork.doImport(au.com.bytecode.opencsv.CSVReader) + org.nuxeo.ecm.csv.CSVImporterWork.doImport(org.apache.commons.csv.CSVParser) org.nuxeo.ecm.csv.CSVImporterWork.importLine(String[], long, int, int, String[]) + org.nuxeo.ecm.csv.CSVImporterWork.importRecord(org.apache.commons.csv.CSVRecord, Map<String, Integer>) org.nuxeo.ecm.csv.CSVImporterWork.computePropertiesMap(long, DocumentType, String[], String[]) + org.nuxeo.ecm.csv.CSVImporterWork.computePropertiesMap(org.apache.commons.csv.CSVRecord, DocumentType, Map<String, Integer>) org.nuxeo.ecm.csv.CSVImporterWork.createOrUpdateDocument(long, String, String, String, Map<String, Serializable>) + org.nuxeo.ecm.csv.CSVImporterWork.createOrUpdateDocument(long, String, String, Map<String, Serializable>) org.nuxeo.ecm.csv.CSVImporterWork.getUserUrl(String) + org.nuxeo.ecm.csv.CSVImporterWork.getUserUrl() New Assert test methods: org.nuxeo.runtime.test.Assert.assertFilesContentEquals(String, String) org.nuxeo.runtime.test.Assert.assertFilesContentEquals(String, String, String)
    • Sprint:
      DevOps Sprint 7
    • Story Points:
      10

      Description

      Apache Commons CSV looks like a promising and active project whereas opencsv has been mostly dormant since 2011. Important bugs in OpenCSV have been fixed in Apache Commons CSV. Some customers ask for the JSON row quoting feature.

      That makes enough reasons to switch from net.sf.opencsv:opencsv to org.apache.commons:commons-csv.

        Attachments

          Issue Links

          is required by

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. NXP-12206 Upgrade dependencies and plugins

          • Major - Major loss of function.
          • Open
          links to

          Web Link CSV-116

          Web Link PHOENIX-53

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: