Uploaded image for project: 'Nuxeo ECM Build/Test Environment'
  1. Nuxeo ECM Build/Test Environment
  2. NXBT-1316

Integrate with the GitHub review approval system

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: HOOKS-1.0.0
    • Fix Version/s: HOOKS-1.1.0
    • Component/s: Captain Hook, GitHub

      Description

      Remove the code review related features from Captain Hook. Let's use GitHub native features.

      Remove all occurrences of ":+1:" concept.

      Communicate the change on convention.

      Use #test-pull-requests Slack channel for testing https://github.com/integrations/slack

      Consider later improvements integrating Captain Hook with GitHub Reviews in dedicated Jira tickets to create.

      Update https://nuxeowiki.atlassian.net/wiki/spaces/NIG/pages/2621941/GitHub

      —

      Pull Requests must be reviewed before merge (https://help.github.com/articles/about-required-reviews-for-pull-requests/). The current review process counts the :+1: in the comments in order to confirm a code review.
      Since GitHub introduced a new code review approval feature (https://help.github.com/articles/approving-a-pull-request-with-required-reviews/), we'll align on the new review status.

        Attachments

          Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. NXBT-2325 Fix CH test_store_pull_request

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved
          is related to

          New Feature - A new feature of the product, which has yet to be developed. NXBT-1583 Integrate QA portal in GitHub PR message

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. NXBT-1848 Leverage GitHub code ownership

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. NXBT-1266 Add a link to the JIRA ticket from a pull request

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. NXBT-1452 Leverage GitHub reviewers feature

          • Major - Major loss of function.
          • Open
          Is referenced in

          [Captain Hook] PR for master: #15 PR for master: #15

            Activity

              People

              • Assignee:
                jcarsique Julien Carsique
                Reporter:
                jcarsique Julien Carsique
                Participants:
                Reviewers:
                Pierre-Gildas Millon, Thomas Roger
              • Votes:
                6 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: