-
Type:
Clean up
-
Status: Acknowledged
-
Priority:
Minor
-
Resolution: Unresolved
-
Affects Version/s: 2022.4.5
-
Fix Version/s: None
-
Component/s: QA / CI / Tests
-
Tags:
-
Team:NOS
It seems the nos.gitty.basePath and studio.gitlocal.basepath properties (I don't really know the difference) are defined at many places, with different random values and hardcoded paths are used on some other places, it should be clean up and defined only in one or two places for consistency and understanding.
It is the cause of the nos-nuxeo-full image not using the same folder than the nos-nuxeo-preview one for example, when you deploy those 2 images locally (one after the other) they find the same nuxeo database (postgres) but not he same git repos.
$ rg local-git-repos docker/nos-nuxeo-gitty/Dockerfile 13:RUN mkdir -p $NUXEO_HOME/gitty/local-git-repos docker/nos-nuxeo-preview/nuxeo-preview.conf 3:studio.gitlocal.basepath=/var/lib/nuxeo/data/local-git-repos 4:nos.gitty.basePath=/var/lib/nuxeo/data/local-git-repos gitty/nos-gitty-mp/src/main/resources/install/templates/gitty/nuxeo.defaults 4:nos.gitty.basePath=${nuxeo.data.dir}/gitty/local-git-repos studio/nuxeo-studio-core/src/main/java/com/nuxeo/studio/core/GitRepositoryServiceLocalImpl.java 68: root = new File(Environment.getDefault().getTemp(), "local-git-repos");
$ rg git_repos
docker/nos-nuxeo-portal/Dockerfile
20: mkdir -p $NUXEO_HOME/studio_git_repos && \
helmfiles/nos/charts.d/nos-portal/templates/configmap.yaml
57: studio.gitlocal.basepath=/opt/nuxeo/server/studio_git_repos
helmfiles/nos/charts.d/nos-portal/templates/deployment.yaml
117: mountPath: /opt/nuxeo/server/studio_git_repos
connect/nuxeo-connect-mp/src/main/resources/install/templates/connect/nuxeo.dev
20:nos.gitty.basePath=${nuxeo.data.dir}/studio_git_repos
connect/nuxeo-connect-mp/src/main/resources/install/templates/connect-local/nuxeo.defaults
37:nos.gitty.basePath=${nuxeo.data.dir}/studio/git_repos
NOTE: DO NOT BREAK THE PROD => changes should only occur in local templates and preview images conf