Uploaded image for project: 'Nuxeo Python Client'
  1. Nuxeo Python Client
  2. NXPY-110

Max retries for all connections

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.1
    • Fix Version/s: 2.2.2
    • Component/s: None

      Description

      The client should be more robust against connection errors like:

      ConnectionError('Connection aborted')
      RemoteDisconnected('Remote end closed connection without response')
      

      From the author of requests:

      If Python sends a request at roughly the same time as the server closes the
      session, then the server will send a RST (as the session is closed). Python
      receives this RST on what it thought was a valid session and throws an
      error.

      This can be handled by setting max_retries in a requests.adapters.HTTPAdapter class (the requests default is 0) which will retry on a ConnectionError.

      Note that we are manually retrying uploads only (3 times). Using the general retry would be helpful for all calls.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours
                  4h