[NXP-8630] Fix inverted event handler EL expression evaluation - Nuxeo Issue Tracker

XML

Word

Printable

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 5.5
Fix Version/s: 5.7.1
Component/s: Automation

Backlog priority:
300
Impact type:

Configuration format change
Upgrade notes:

Hide

Use the new parameter "condition" instead of "expression" when migrating event handlers

Show
Use the new parameter "condition" instead of "expression" when migrating event handlers

Description

For instance,

If we have an expression like

!Document.hasFacet("Folderish")

It will execute the event handler only if the document DOES HAVE the facet folderish

From org.nuxeo.ecm.automation.core.events.EventHandler:250

        if (expression != null) {
            if (expr == null) {
                expr = Scripting.newExpression(expression);
            }
            if ((Boolean) expr.eval(ctx)) {
                return false;
            }
        }
        return true;

is wrong and should be

        if (expression != null) {
            if (expr == null) {
                expr = Scripting.newExpression(expression);
            }
            if (!(Boolean) expr.eval(ctx)) {
                return false;
            }
        }
        return true;

Attachments

Issue Links

depends on

NXS-955 Fix inverted event handler EL expression evaluation and handle existing expression

Resolved

is required by

NXP-13115 automation event handler descriptors should be contributable in Java

Resolved

Activity

People

Assignee:

Anahide Tchertchian

Reporter:

Sun Tan

Participants:

Anahide Tchertchian, Sun Tan, Thierry Martins

Votes:

0 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

2011-12-30 20:57

Updated:

2013-11-25 14:48

Resolved:

2012-11-16 10:51

Time Tracking

Estimated:

Remaining:

Logged:

Not Specified