Uploaded image for project: 'Nuxeo Platform'
  1. Nuxeo Platform
  2. NXP-32548

Review Comments: Related variable name, a11y & code refactoring

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Admin Center

      Description

      Comments:
      - please change the variable menu to "item" or "menuItem"

      -  please change function name to itemSelected or menuItemSelected for both (click) & (keyup.enter)
       - use hex value instead of the string 'black'
      - Is tabindex required ? This is an anchor tag for which focus works by default

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: