-
Type:
Bug
-
Status: Resolved
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: ADDONS_10.10, ADDONS_11.1
-
Fix Version/s: ADDONS_10.10, ADDONS_11.1
-
Component/s: Aspera Connector
-
Environment:Jenkins X
-
Tags:
-
Impact type:Configuration Change
-
Sprint:nxApps 2020 Cycle 11
-
Story Points:1
We are not able to test all the code in DRY_RUN mode, but if we have a deep look on this part we can say :
if (params.dryRun && params.dryRun != '') { env.DRY_RUN_RELEASE = params.dryRun if (env.DRY_RUN_RELEASE == 'true') { echo ''' ---------------------------------------- Update Slack Channel ---------------------------------------- ''' env.SLACK_CHANNEL = 'infra-napps' } else { env.SLACK_CHANNEL = 'pr-aspera' } }
we will never enter on the 'else' statement.
that's why it will be better to rewrite this part
if (params.dryRun && params.dryRun != '') { env.DRY_RUN_RELEASE = params.dryRun if (env.DRY_RUN_RELEASE == 'true') { echo ''' ---------------------------------------- Update Slack Channel ---------------------------------------- ''' env.SLACK_CHANNEL = 'infra-napps' } } else { env.SLACK_CHANNEL = 'pr-aspera' env.DRY_RUN_RELEASE = 'false' }