Uploaded image for project: 'Nuxeo Platform'
  1. Nuxeo Platform
  2. NXP-25782

Fix marshaller unregistration

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.10
    • Component/s: Core IO

      Description

      Since NXP-25186, logic has changed in MarshallerRegistryImpl.
      Contribution has not registered/unregistered directly using register/unregister methods. They are saved in generic registry and then registered during startup.
      This leads to an issue during hot reload because we try to register again marshallers and we don't unregister marshallers removed during hot reload.

      We shouldn't re-create marshallers during start, or at least only ones that have changed and we should unregister marshallers removed during hot reload.

      Symptom of issue is this kind of log:

      2018-09-13 10:36:41,833 WARN  [http-nio-0.0.0.0-8080-exec-9] [org.nuxeo.ecm.core.io.registry.MarshallerRegistryImpl] The marshaller org.nuxeo.ecm.platform.thumbnail.io.ThumbnailJsonEnricher is already registered.
      

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day
                  1d