Uploaded image for project: 'Nuxeo Platform'
  1. Nuxeo Platform
  2. NXP-22623

Make ConditionalIgnoreRule.Feature declare a test rule

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 9.2
    • Fix Version/s: 9.2
    • Component/s: Runtime, Tests

      Description

      Due to new runtime component loading has a bit changed. We can't ignore tests in @Before method if an incompatible contribution is deployed with @Deploy or @LocalDeploy declared on the method.

      Because @Before is called after processing of deploy annotations.

      We can use ConditionalIgnoreRule.Ignore annotation on class to ignore this test class. But currently this system process the class annotation during the same step it could process the method annotation, just after the the processing of deploy annotations on method.

      We need to make ConditionalIgnoreRule a TestRule declared as a @Rule, as it it will be processed for each method before running @Rule for MethodRule.

      As it, ConditionalIgnoreRule.Ignore annotation on class will be processed after the runtime start based on class annotation, just before entering the method context execution of JUnit.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours
                  4h