Uploaded image for project: 'Nuxeo Platform'
  1. Nuxeo Platform
  2. NXP-20632

Fix ignore of test annotated RandomBug.Repeat when using @SuiteClasses

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 8.4-SNAPSHOT
    • Fix Version/s: QualifiedToSchedule
    • Component/s: Tests
    • Tags:
    • Sprint:
      nxSL Sprint 9.1.1
    • Story Points:
      5

      Description

      When a test class is annotated with @RandomBug.Repeat and it references test classes with @SuiteClasses, the @RandomBug.Repeat annotation should be taken into account in the tests from the suite classes.

      This was detected on TestESAuditChangeFinder form nuxeo-drive-elasticsearch at the time where the workaround for NXP-20517 and NXP-20962 had not yet been applied, see old code: https://github.com/nuxeo/nuxeo-drive-server/blob/3da94b298f642eb280855da7897cfea1940cf901/nuxeo-drive-elasticsearch/src/test/java/org/nuxeo/drive/elasticsearch/TestESAuditChangeFinder.java

      When a test from its SuiteClasses was failing, it was:

      • Not repeated with the default mode RELAX, making IT-nuxeo-master-build fail at first failure
      • Not bypassed with the BYPASS mode, making fail the T&P jobs at first failure

      For NXP-20517 and NXP-20962 we temporarily pushed a workaround by putting the @RandomBug.Repeat annotation on the test suite classes themselves, see https://github.com/nuxeo/nuxeo-drive-server/commit/3613902b8af9a30cd4251429402ca718f4221f8d and https://github.com/nuxeo/nuxeo-drive-server/commit/46281f20d513a8ec4520891576262651b1e939a3
      This is not acceptable because TestSQLAuditChangeFinder, the other test class running thes suites, is impacted by the annotation.

      When the current issue is fixed, we should put back the annotation on TestESAuditChangeFinder.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: