Uploaded image for project: 'Nuxeo Platform'
  1. Nuxeo Platform
  2. NXP-18425

Don't use dots in custom HTTP headers

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.10-HF01, 8.1
    • Component/s: Core IO

      Description

      We use dots in some of our custom HTTP headers, for instance X-NXenrichers.document, X-NXfetch.entity or X-NXtranslate.entity. These are legal according to the HTTP spec, but nginx by default doesn't allow them (or underscores for that matters). And this is a problem for customers using nginx.

      A workaround is to configure nginx with ignore_invalid_headers and underscores_in_headers but this is still something easily forgotten.

      So we should use something more mainstream as a separator, just a -. This requires changing all clients and server parsing, but keeping the . for a while for backward compatibility. (The server code is mostly in RenderingContextImpl.)

      See https://trac.nginx.org/nginx/ticket/629#comment:2 for a discussion by nginx maintainers as why they won't change their behavior.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: