Uploaded image for project: 'Nuxeo Platform'
  1. Nuxeo Platform
  2. NXP-17432

nuxeo-binary-metadata must not write directly to an existing Binary

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 7.2
    • Fix Version/s: 7.4
    • Component/s: Binary Metadata
    • Impact type:
      API change
    • Upgrade notes:
      Hide

      In BinaryMetadataService and BinaryMetadataProcessor, the writeMetadata methods taking a Blob now return a new Blob instead of a boolean.

      Show
      In BinaryMetadataService and BinaryMetadataProcessor, the writeMetadata methods taking a Blob now return a new Blob instead of a boolean.

      Description

      nuxeo-binary-metadata directly updates the binary's underlying File when it updates the metadata for a Blob. This is incorrect as the binary may be shared, its hash will be incorrect, and also for binaries coming from remote storage like S3 it's actually in a cache so may disappear and the effect of the write would be undone.

      Instead, exiftool should work on a temporary file and create a new Blob from it.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: