[NXP-14868] Cleanup CachingBinaryManager implementations and fix repositoryName init - Nuxeo Issue Tracker

XML

Word

Printable

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 5.4.1
Fix Version/s: 6.0
Component/s: Core

Impact type:

API change
Upgrade notes:
Hide

New methods:

org.nuxeo.ecm.core.storage.binary.AbstractBinaryManager.getDigest()

org.nuxeo.ecm.core.storage.binary.CachingBinaryManager.initialize(BinaryManagerDescriptor)

org.nuxeo.ecm.core.storage.binary.CachingBinaryManager.initializeCache(String, FileStorage)

Moved deprecated constants from org.nuxeo.launcher.config.Environment to org.nuxeo.common.Environment
Show
New methods: org.nuxeo.ecm.core.storage.binary.AbstractBinaryManager.getDigest() org.nuxeo.ecm.core.storage.binary.CachingBinaryManager.initialize(BinaryManagerDescriptor) org.nuxeo.ecm.core.storage.binary.CachingBinaryManager.initializeCache(String, FileStorage) Moved deprecated constants from org.nuxeo.launcher.config.Environment to org.nuxeo.common.Environment
Sprint:
DevOps Sprint 5, DevOps Sprint 6
Story Points:
1

Description

Among with the three implementations of CachingBinaryManager, the two classes JCloudsBinaryManager and S3BinaryManager override the field repositoryName making its initialization ineffective since the field used elsewhere in the inherited code is AbstractBinaryManager.repositoryName. It seems to work fine nevertheless thanks to default fall-backs.
=> Remove that field.

In the mean time, the code needs some cleanup and factorization.

Attachments

Activity

People

Assignee:

Julien Carsique

Reporter:

Julien Carsique

Participants:

Jenkins, Julien Carsique

Votes:

0 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

2014-07-29 13:07

Updated:

2015-11-24 15:52

Resolved:

2014-08-26 16:39

Time Tracking

Estimated:

Remaining:

Logged:

Not Specified