Uploaded image for project: 'Nuxeo Drive '
  1. Nuxeo Drive
  2. NXDRIVE-2135

Check for proxy instantiation success when using a PAC

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1221
    • Fix Version/s: 4.4.5
    • Component/s: Proxy

      Description

      Error

      Sentry Issue: NUXEO-DRIVE-2WN

      AttributeError: 'NoneType' object has no attribute 'find_proxy_for_url'
  File "nxdrive\utils.py", line 852, in guess_server_url
  File "nxdrive\client\proxy.py", line 129, in settings
  File "lib\site-packages\pypac\resolver.py", line 97, in get_proxy_for_requests
  File "lib\site-packages\pypac\resolver.py", line 82, in get_proxy
  File "lib\site-packages\pypac\resolver.py", line 60, in get_proxies

      Analysis

      The code does not check for the return value. In fact, here _resolver can be None:

      :return: The first valid parsed PAC file according to the criteria, or `None` if nothing was found.

        Attachments

          Issue Links

          Is referenced in

          [Captain Hook] PR for master: #1925 PR for master: #1925

          [Captain Hook] PR for master: #1969 PR for master: #1969

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h