[NXDRIVE-2049] Skip malformed local configuration files - Nuxeo Issue Tracker

XML

Word

Printable

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: NoFixVersionApplicable
Fix Version/s: 4.4.2
Component/s: Configuration

Tags:
- nxDrive
Sprint:
nxDrive 11.1.29
Story Points:
1

Description

Error

Command line arguments:

uninstall

Exception:

Traceback (most recent call last):
  File "nxdrive\__main__.py", line 117, in main
  File "nxdrive\commandline.py", line 481, in handle
  File "nxdrive\commandline.py", line 392, in parse_cli
  File "nxdrive\commandline.py", line 433, in load_config
  File "configparser.py", line 696, in read
  File "configparser.py", line 1079, in _read
configparser.MissingSectionHeaderError: File contains no section headers.
file: 'C:\\Users\\Windows10\\.nuxeo-drive\\config.ini', line: 1
'ï»¿[DEFAULT]\n'

Analysis

▶ file config.ini 
config.ini: UTF-8 Unicode (with BOM) text, with CRLF line terminators

Fix

This is a 2 steps fix:

The config file should be opened with a specified encoding (UTF-8, always) (see https://stackoverflow.com/a/1648865/1117028).
We should skip any errors and print a warning with the stacktrace.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

config.ini
0.1 kB
2020-02-13 16:11
fix.patch
1 kB
2020-02-13 16:54

Activity

People

Assignee:

Romain Grasland

Reporter:

Mickaël Schoentgen

Participants:

Jenkins, Mickaël Schoentgen, Romain Grasland

Votes:

0 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

2020-02-13 16:10

Updated:

2020-03-05 20:11

Resolved:

2020-03-05 18:15

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 30m