Uploaded image for project: 'Nuxeo Drive '
  1. Nuxeo Drive
  2. NXDRIVE-1886

Direct Edit should be robust against connection errors

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.1.4
    • Fix Version/s: 4.3.0
    • Component/s: Direct Edit

      Description

      Issue

      Sentry Issue: NUXEO-DRIVE-1YT

      Cannot unlock document WindowsPath('...')
      
      timeout: timed out
        File "lib\site-packages\urllib3\connection.py", line 160, in _new_conn
        File "lib\site-packages\urllib3\util\connection.py", line 80, in create_connection
        File "lib\site-packages\urllib3\util\connection.py", line 70, in create_connection
      
      ConnectTimeoutError: (<urllib3.connection.VerifiedHTTPSConnection object at 0x034C1F10>, 'Connection to SERVER timed out. (connect timeout=5)')
        File "lib\site-packages\urllib3\connectionpool.py", line 603, in urlopen
        File "lib\site-packages\urllib3\connectionpool.py", line 344, in _make_request
        File "lib\site-packages\urllib3\connectionpool.py", line 843, in _validate_conn
        File "lib\site-packages\urllib3\connection.py", line 316, in connect
        File "lib\site-packages\urllib3\connection.py", line 165, in _new_conn
      
      MaxRetryError: HTTPSConnectionPool(host='SERVER', port=443): Max retries exceeded with url: /nuxeo/site/automation/Document.Unlock (Caused by ConnectTimeoutError(<urllib3.connection.VerifiedHTTPSConnection object at 0x034C1F10>, 'Connection to SERVER timed out. (connect timeout=5)'))
        File "lib\site-packages\requests\adapters.py", line 449, in send
        File "lib\site-packages\urllib3\connectionpool.py", line 670, in urlopen
        File "lib\site-packages\urllib3\connectionpool.py", line 670, in urlopen
        File "lib\site-packages\urllib3\connectionpool.py", line 670, in urlopen
        File "lib\site-packages\urllib3\connectionpool.py", line 670, in urlopen
        File "lib\site-packages\urllib3\connectionpool.py", line 670, in urlopen
        File "lib\site-packages\urllib3\connectionpool.py", line 641, in urlopen
        File "lib\site-packages\urllib3\util\retry.py", line 399, in increment
      
      ConnectTimeout: HTTPSConnectionPool(host='SERVER', port=443): Max retries exceeded with url: /nuxeo/site/automation/Document.Unlock (Caused by ConnectTimeoutError(<urllib3.connection.VerifiedHTTPSConnection object at 0x034C1F10>, 'Connection to SERVER timed out. (connect timeout=5)'))
        File "nxdrive\direct_edit.py", line 596, in _handle_lock_queue
        File "nxdrive\client\remote_client.py", line 801, in unlock
        File "nxdrive\client\remote_client.py", line 139, in execute
        File "lib\site-packages\nuxeo\operations.py", line 203, in execute
        File "lib\site-packages\nuxeo\client.py", line 272, in request
        File "lib\site-packages\nuxeo\client.py", line 267, in request
        File "lib\site-packages\requests\sessions.py", line 533, in request
        File "lib\site-packages\requests\sessions.py", line 646, in send
        File "lib\site-packages\requests\adapters.py", line 504, in send
      

      Fix

      DirectEdit HTTP call must be robust against connection errors. As introduced in NXDRIVE-1649, we could leverage CONNECTION_ERROR exceptions and repush the document in the queue.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 10 minutes
                  2h 10m