Uploaded image for project: 'Nuxeo Drive '
  1. Nuxeo Drive
  2. NXDRIVE-1816

Remove access to private methods

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.1.4
    • Fix Version/s: 4.2.0
    • Component/s: Framework

      Description

      Make a big cleanup for remaining private accesses (as creating specific tickets would be less efficient):

      $ python -m pylint --disable=all --enable=protected-access nxdrive
      ************* Module nxdrive.logging_config
      nxdrive/logging_config.py:179: [W0212(protected-access), check_level] Access to a protected member _nameToLevel of a client class
      ************* Module nxdrive.options
      nxdrive/options.py:422: [W0212(protected-access), MetaOptions.update] Access to a protected member _get_kwargs of a client class
      ************* Module nxdrive.direct_edit
      nxdrive/direct_edit.py:351: [W0212(protected-access), DirectEdit._get_info] Access to a protected member _base_folder_ref of a client class
      nxdrive/direct_edit.py:696: [W0212(protected-access), DirectEdit._handle_upload_queue] Access to a protected member _check_ref of a client class
      ************* Module nxdrive.utils
      nxdrive/utils.py:658: [W0212(protected-access), get_certificate_details] Access to a protected member _test_decode_cert of a client class
      nxdrive/utils.py:658: [W0212(protected-access), get_certificate_details] Access to a protected member _ssl of a client class
      ************* Module nxdrive.translator
      nxdrive/translator.py:129: [W0212(protected-access), Translator.set] Access to a protected member _set of a client class
      nxdrive/translator.py:143: [W0212(protected-access), Translator.locale] Access to a protected member _locale of a client class
      nxdrive/translator.py:149: [W0212(protected-access), Translator.get] Access to a protected member _get of a client class
      nxdrive/translator.py:155: [W0212(protected-access), Translator.languages] Access to a protected member _languages of a client class
      ************* Module nxdrive.__main__
      nxdrive/__main__.py:105: [W0212(protected-access), main] Access to a protected member _contexts of a client class
      ************* Module nxdrive.report
      nxdrive/report.py:82: [W0212(protected-access), Report.copy_db] Access to a protected member _lock of a client class
      nxdrive/report.py:84: [W0212(protected-access), Report.copy_db] Access to a protected member _db of a client class
      nxdrive/report.py:84: [W0212(protected-access), Report.copy_db] Access to a protected member _db of a client class
      nxdrive/report.py:86: [W0212(protected-access), Report.copy_db] Access to a protected member _db of a client class
      ************* Module nxdrive.updater.darwin
      nxdrive/updater/darwin.py:34: [W0212(protected-access), Updater.install] Access to a protected member _cleanup of a client class
      ************* Module nxdrive.manager
      nxdrive/manager.py:287: [W0212(protected-access), Manager._create_extension_listener] Access to a protected member _init of a client class
      nxdrive/manager.py:288: [W0212(protected-access), Manager._create_extension_listener] Access to a protected member _listen of a client class
      nxdrive/manager.py:339: [W0212(protected-access), Manager.stop] Access to a protected member _cleanup of a client class
      ************* Module nxdrive.updater.base
      nxdrive/updater/base.py:211: [W0212(protected-access), BaseUpdater._get_update_status] Access to a protected member _get_server_login_type of a client class
      ************* Module nxdrive.gui.api
      nxdrive/gui/api.py:60: [W0212(protected-access), QMLDriveApi.__init__] Access to a protected member _open_authentication_dialog of a client class
      nxdrive/gui/api.py:214: [W0212(protected-access), QMLDriveApi.get_threads] Access to a protected member _get_threads of a client class
      nxdrive/gui/api.py:362: [W0212(protected-access), QMLDriveApi.web_update_token] Access to a protected member _get_server_login_type of a client class
      nxdrive/gui/api.py:366: [W0212(protected-access), QMLDriveApi.web_update_token] Access to a protected member _force_downgrade of a client class
      nxdrive/gui/api.py:374: [W0212(protected-access), QMLDriveApi.web_update_token] Access to a protected member _open_authentication_dialog of a client class
      nxdrive/gui/api.py:467: [W0212(protected-access), QMLDriveApi._bind_server] Access to a protected member _get_default_server_type of a client class
      nxdrive/gui/api.py:562: [W0212(protected-access), QMLDriveApi.web_authentication] Access to a protected member _get_default_server_type of a client class
      nxdrive/gui/api.py:572: [W0212(protected-access), QMLDriveApi.web_authentication] Access to a protected member _get_server_login_type of a client class
      nxdrive/gui/api.py:587: [W0212(protected-access), QMLDriveApi.web_authentication] Access to a protected member _force_downgrade of a client class
      ************* Module nxdrive.gui.application
      nxdrive/gui/application.py:303: [W0212(protected-access), Application._fill_qml_context] Access to a protected member _singleton of a client class
      nxdrive/gui/application.py:356: [W0212(protected-access), Application._init_translator] Access to a protected member _singleton of a client class
      nxdrive/gui/application.py:668: [W0212(protected-access), Application._open_authentication_dialog] Access to a protected member _callback_params of a client class
      nxdrive/gui/application.py:885: [W0212(protected-access), Application._setup_notification_center] Access to a protected member _manager of a client class
      ************* Module nxdrive.osi.windows.windows
      nxdrive/osi/windows/windows.py:43: [W0212(protected-access), WindowsIntegration._init] Access to a protected member _engine_definitions of a client class
      ************* Module nxdrive.engine.processor
      nxdrive/engine/processor.py:784: [W0212(protected-access), Processor._synchronize_locally_created] Access to a protected member _lock of a client class
      ************* Module nxdrive.engine.engine
      nxdrive/engine/engine.py:363: [W0212(protected-access), Engine.rollback_delete] Access to a protected member _scan_remote of a client class
      ************* Module nxdrive.engine.dao.sqlite
      nxdrive/engine/dao/sqlite.py:332: [W0212(protected-access), ConfigurationDAO._get_read_connection] Access to a protected member _conn of a client class
      nxdrive/engine/dao/sqlite.py:338: [W0212(protected-access), ConfigurationDAO._get_read_connection] Access to a protected member _conn of a client class
      nxdrive/engine/dao/sqlite.py:339: [W0212(protected-access), ConfigurationDAO._get_read_connection] Access to a protected member _conn of a client class
      nxdrive/engine/dao/sqlite.py:341: [W0212(protected-access), ConfigurationDAO._get_read_connection] Access to a protected member _conn of a client class
      ************* Module nxdrive.engine.watcher.local_watcher
      nxdrive/engine/watcher/local_watcher.py:841: [W0212(protected-access), LocalWatcher._handle_watchdog_event_on_known_pair] Access to a protected member _queue_pair_state of a client class
      ************* Module nxdrive.client.remote_client
      nxdrive/client/remote_client.py:449: [W0212(protected-access), Remote.upload_chunks] Access to a protected member _upload_idx of a client class
      nxdrive/client/remote_client.py:479: [W0212(protected-access), Remote.upload_chunks] Access to a protected member _upload_idx of a client class
      

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours
                4h