Uploaded image for project: 'Nuxeo Drive '
  1. Nuxeo Drive
  2. NXDRIVE-1732

Better handling of the Direct Edit protocol

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 4.1.3
    • Fix Version/s: 4.1.4
    • Component/s: Tests

      Description

      General Issue

      Drive handle the custom protocol URL (nxdrive://) only when it is already running. We send it to the running instance.
      If it is not running, the URL is sent to the Direct Edit process via Options.protocol_url and thus the following errors.

      Issue 1

      Sentry Issue: NUXEO-DRIVE-1J8

      ValueError: Unsupported command 'nxdrive://edit/https/nuxeo.server.com/nuxeo/repo/default/nxdocid/9f23923a-dcf1-420a-acab-adcf240859f6/filename/Numéros.docx' in protocol handler
        File "nxdrive\utils.py", line 483, in wrapper
        File "nxdrive\gui\application.py", line 1203, in _handle_connection
        File "nxdrive\gui\application.py", line 1123, in _handle_nxdrive_url
        File "nxdrive\utils.py", line 806, in parse_protocol_url
      
      Issue 2

      Sentry Issue: NUXEO-DRIVE-19W

      url = 'nxdrive://token/TOKEN/user/USERNAME'
      KeyError: 'server_url'
        File "nxdrive\engine\workers.py", line 171, in run
        File "nxdrive\direct_edit.py", line 672, in _execute
        File "nxdrive\direct_edit.py", line 139, in handle_url
      
      Thread EXCEPTION
      

      Actions

      1. ensure the given URL can be handled by direct Edit.
      2. Add unit tests for parse_protocol_url().

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours
                2h