Uploaded image for project: 'Nuxeo Drive '
  1. Nuxeo Drive
  2. NXDRIVE-1672

Ensure Application.update_status() is passed an Engine

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.1.2
    • Fix Version/s: 4.1.3
    • Component/s: Framework

      Description

      Error

      Sentry Issue: NUXEO-DRIVE-ZE

      AttributeError: 'QThread' object has no attribute 'uid'
        File "nxdrive\gui\application.py", line 1220, in update_status
      

      Fix

      diff --git a/nxdrive/gui/application.py b/nxdrive/gui/application.py
      index f358a036..ad308eb0 100644
      --- a/nxdrive/gui/application.py
      +++ b/nxdrive/gui/application.py
      @@ -1258,8 +1258,11 @@ class Application(QApplication):
               """
               sync_state = error_state = update_state = ""
       
      +        if not isinstance(engine, Engine):
      +            log.error(f"Need an Engine, got {engine!r}")
      +            return
      +
               update_state = self.manager.updater.status
      -        self.refresh_conflicts(engine.uid)
       
               # Check synchronization state
               if self.manager.restart_needed:
      

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 10 minutes
                  10m