Uploaded image for project: 'Nuxeo Drive '
  1. Nuxeo Drive
  2. NXDRIVE-1545

Avoid sending NotFound exceptions to Sentry

    XMLWordPrintable

    Details

    • Type: Clean up
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0.4
    • Fix Version/s: 4.1.0
    • Component/s: Local client

      Description

      That exception is raised when a document does not exist on the server. We are currently logging an exception when it happens. Lower those logs to not pollute Sentry events.

      Stacktrace:

      NotFound: Could not find doc into ...: ref=..., os_path=...)
        File "nxdrive\engine\watcher\local_watcher.py", line 1170, in handle_watchdog_event
        File "nxdrive\engine\watcher\local_watcher.py", line 274, in scan_pair
        File "nxdrive\client\local_client.py", line 407, in get_info
      

      Possible fix:

      diff --git a/nxdrive/client/local_client.py b/nxdrive/client/local_client.py
      index 84af3378..c98354bd 100644
      --- a/nxdrive/client/local_client.py
      +++ b/nxdrive/client/local_client.py
      @@ -471,7 +471,7 @@ FolderType=Generic
               if remote_digest_algorithm == self._digest_func:
                   return False
       
      -        file_info = self.get_info(local_path)
      +        file_info = self.try_get_info(local_path)
               if not file_info:
                   return False
               digest = file_info.get_digest(digest_func=remote_digest_algorithm)
      @@ -524,7 +524,7 @@ FolderType=Generic
                   try:
                       info = self.get_info(child_ref)
                   except NotFound:
      -                log.exception(
      +                log.warning(
                           "The child file has been deleted in the mean time"
                           " or while reading some of its attributes"
                       )
      

      Sentry references:

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m