Uploaded image for project: 'Nuxeo ECM Build/Test Environment'
  1. Nuxeo ECM Build/Test Environment
  2. NXBT-2071

Cleanup libfaac mentions on nuxeo/ffmpeg-nuxeo scripts and README

    XMLWordPrintable

    Details

    • Type: Clean up
    • Status: Open
    • Priority: Detail
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: FFmpeg

      Description

      In NXP-22777 the usage of libfaac was removed from nuxeo/nuxeo-platform-video (we now use the ffmpeg embedded aac encoder instead). However, there are still mentions of libfaac in nuxeo/ffmpeg-nuxeo that should be cleaned up, such as:

      build-all.sh
      if test -n "$(apt-cache search libfaac-dev)"; then
        LIBFAAC_DEFAULT=true
      else
        LIBFAAC_DEFAULT=false
      fi
        LIBFAAC=${1:-$LIBFAAC_DEFAULT}
      
      README.md
      By default, it will not include AAC support since the `libfaac` libraries contain some non-free code;
      see the `LIBFAAC` parameter.
      
      prepare-packages.sh
      if [ "$LIBFAAC" = "true" ]; then
        apt-get -y install libfaac-dev
      
      build-ffmpeg.sh
      if [ "$LIBFAAC" = "true" ]; then
        FAACOPTIONS="--enable-libfaac --enable-nonfree --enable-libx264"
      else
        FAACOPTIONS="--disable-libx264"
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                mnixo Miguel Nixo
                Participants:
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: