-
Type: Improvement
-
Status: Resolved
-
Priority: Minor
-
Resolution: Done
-
Affects Version/s: None
-
Component/s: Continuous Integration
-
Tags:
-
Backlog priority:500
-
Impact type:Configuration Change
-
Upgrade notes:
-
Sprint:DevOps-21, DevOps-22
-
Story Points:1
Currently the fact of using 2 boolean parameters is confusing, as there are 4 combinations but only 3 available behaviors:
- PUSH_IF_SUCCEED && CREATE_PR => create PR
- PUSH_IF_SUCCEED && !CREATE_PR => push
- !PUSH_IF_SUCCEED && !CREATE_PR => nothing
- !PUSH_IF_SUCCEED && CREATE_PR => nothing, so same as 3., but some people might think that it will create a PR
Suggestion: replace these 2 parameters by a single one ON_SUCCESS using a dropdown list with 3 choices:
- Create PR => same as current 1.
- Push => same as current 2.
- Dry run / status check => same as current 3. and 4.
As a reminder, here is the current pseudo-code:
if [ "$MERGE_BEFORE_BUILD" != true ]; then # merge fi if [ "$PUSH_IF_SUCCEED" = true ]; then if [ "$MERGE_BEFORE_BUILD" = true ]; then # pull fi if $CREATE_PR; then # PR else # Push fi fi