Uploaded image for project: 'Nuxeo Elements'
  1. Nuxeo Elements
  2. ELEMENTS-765

Do not hard-code css values like min-height in nuxeo-document-preview

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2
    • Fix Version/s: 2.4.0
    • Component/s: Layouts

      Description

      nuxeo-document-preview has a hard-coded min-height value for several of the elements (nuxeo-image-viewer, nuxeo-pdf-viewer, etc.). This makes the element very difficult to work with (impossible, in my case, as I need it to be smaller).

      We should provide CSS mixins for these values (e.g. --nuxeo-image-viewer-min-height) so that they can be changed.

      Alternatively, make a container where you hard-code the height if needed, but but abstract the rest of the functionality as a re-usable element, and use a slot.

      Clarification: the slotted() syntax can't be used because 1) these are not top-level children and 2) there is no slot.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 10 minutes
                10m