Uploaded image for project: 'Nuxeo Platform'
  1. Nuxeo Platform
  2. NXP-22310

Upgrade RichFaces in 7.10 from 4.5.0.Alpha3 to 4.5.x.Final

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Seam / JSF UI

      Description

      While investigating on NXP-21585 for 7.10, I found out that the bug is similar to NXP-8153: "the listener to the "switch" behavior is registered twice => when clicking, the calendar is expanded and collapsed just after".
      It is due to the version of jQuery (1.8.3) embedded in RichFaces 4.5.0.Alpha3.

      The faulty code is https://github.com/richfaces/richfaces/blob/86fa1fc02e065c857a9fc36144b3d468160bf3bf/core/src/main/resources/META-INF/resources/org.richfaces/jquery.js#L6019 which evaluates the scripts included in the fancybox, for instance the one that instantiates the RichFaces.ui.Calendar for the date widget, leading to the duplicate listener registration.

      This has been fixed in Richfaces 4.5.0.Final thanks to the jQuery upgrade from 1.8.3 to 1.11.1, see https://github.com/richfaces/richfaces/commit/e317a40098ee4e1cace51aaade70b22e7468e0d6 and https://issues.jboss.org/browse/RF-13761.

      So upgrading from 4.5.0.Alpha3 to 4.5.x.Final must be considered. This has already been discussed in TL-133.
      Then we need to measure the impacts, possible regressions, etc.

      We could either:

      • Upgrade from 4.5.0.Alpha3 to 4.5.0.Final which is the minimum upgrade required to fix NXP-21585 (and maybe other bugs) and check the status.
      • Upgrade from 4.5.0.Alpha3 to 4.5.12.Final to align with 8.10 / master, and again, check the status.

      Let's launch 2 T&P, one for each upgrade path.

      See:

      • NXP-15785 for the RichFaces upgrade in 8.10
      • NXP-20596 about a backport needed in case of upgrade

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day
                  1d

                    PagerDuty

                    Error rendering 'com.pagerduty.jira-server-plugin:PagerDuty'. Please contact your Jira administrators.