Uploaded image for project: 'Nuxeo Drive '
  1. Nuxeo Drive
  2. NXDRIVE-2115

Fix flake8 issues following the update to pyflakes 2.2.0

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: NoFixVersionApplicable
    • Fix Version/s: 4.4.2
    • Component/s: Framework

      Description

      Flake8 is getting better and better, and the last update found new issues:

      ▶ tox -e lint
      lint create: /home/tiger-222/projects/nuxeo-drive/.tox/lint
      lint installdeps: -rtools/deps/requirements-pip.txt, -rtools/deps/requirements-lint.txt
      lint installed: entrypoints==0.3,flake8==3.7.9,mccabe==0.6.1,pycodestyle==2.5.0,pyflakes==2.2.0
      lint run-test-pre: PYTHONHASHSEED='3288529476'
      lint run-test: commands[0] | python -m flake8 nxdrive
      nxdrive/utils.py:1179:29: F999 f-string is missing placeholders
      nxdrive/engine/processor.py:451:23: F999 f-string is missing placeholders
      nxdrive/engine/dao/sqlite.py:774:36: F999 f-string is missing placeholders
      nxdrive/engine/watcher/local_watcher.py:933:31: F999 f-string is missing placeholders
      nxdrive/engine/watcher/local_watcher.py:937:27: F999 f-string is missing placeholders
      nxdrive/client/remote_client.py:492:31: F999 f-string is missing placeholders
      nxdrive/updater/darwin.py:73:21: F999 f-string is missing placeholders
      nxdrive/osi/windows/windows.py:100:27: F999 f-string is missing placeholders
      nxdrive/gui/folders_model.py:246:25: F999 f-string is missing placeholders
      
      ▶ tox -e lint
      lint installed: entrypoints==0.3,flake8==3.7.9,mccabe==0.6.1,pycodestyle==2.5.0,pyflakes==2.2.0
      lint run-test-pre: PYTHONHASHSEED='3647079798'
      lint run-test: commands[0] | python -m flake8 nxdrive
      lint run-test: commands[1] | python -m flake8 tests
      tests/integration/windows/utils.py:35:25: F999 f-string is missing placeholders
      tests/integration/windows/test_cli_sub_command.py:167:12: F999 f-string is missing placeholders
      tests/integration/windows/test_cli_sub_command.py:172:12: F999 f-string is missing placeholders
      tests/integration/windows/test_cli_sub_command.py:178:12: F999 f-string is missing placeholders
      tests/old_functional/test_synchronization_dedup.py:116:28: F999 f-string is missing placeholders
      tests/unit/test_utils.py:451:35: F999 f-string is missing placeholders
      tests/unit/test_utils.py:771:11: F999 f-string is missing placeholders
      tests/unit/test_windows_registry.py:10:9: F999 f-string is missing placeholders
      tests/unit/test_windows_registry.py:19:9: F999 f-string is missing placeholders
      tests/unit/test_windows_registry.py:24:9: F999 f-string is missing placeholders
      tests/unit/test_windows_registry.py:30:9: F999 f-string is missing placeholders
      
      ▶ tox -e lint
      lint installed: entrypoints==0.3,flake8==3.7.9,mccabe==0.6.1,pycodestyle==2.5.0,pyflakes==2.2.0
      lint run-test-pre: PYTHONHASHSEED='259675966'
      lint run-test: commands[0] | python -m flake8 nxdrive
      lint run-test: commands[1] | python -m flake8 tests
      lint run-test: commands[2] | python -m flake8 tools
      tools/scripts/check_update_process.py:260:17: F999 f-string is missing placeholders
      tools/scripts/check_update_process.py:261:17: F999 f-string is missing placeholders
      tools/scripts/check_update_process.py:262:17: F999 f-string is missing placeholders
      

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 15 minutes
                15m

                  PagerDuty

                  Error rendering 'com.pagerduty.jira-server-plugin:PagerDuty'. Please contact your Jira administrators.